[Users] [Bug 4130] New: Please reconsider merging the patch syntax highlight

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4130

Bug ID: 4130
Summary: Please reconsider merging the patch syntax highlight
Classification: Unclassified
Product: Claws Mail
Version: other
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P3
Component: UI/Message View
Assignee: ***@lists.claws-mail.org
Reporter: ***@wp.pl

Three years back I submitted a patch to highlight git --diff syntax in-line
inside email bodies. It was rejected due to fear of false positives.

I've used it since and never had a false positive. I have also found that
other people have very similar patches on GitHub, which makes me thinks its a
popular feature.

I have had a quite a few of my coworkers start using my fork of Claws just to
get the patch coloring, and subsequently go back to Thunderbird because of the
extra hassle of having to compile from source and rebase. I think it would be
a really good thing for the project if the feature got merged.

Patches are available here:
https://github.com/kuba-moo/claws-mail/commit/ed5adc67276e7ee0e50c031daccfddcc92488e30
https://github.com/kuba-moo/claws-mail/commit/36300a476c2dc401dd78e3396a6b19848041c08f

Please let me know if I can improve them somehow.

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4130

--- Comment #1 from Paul <***@claws-mail.org> ---
Can you attach the patches here, please?

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4130

--- Comment #2 from Jakub Kici&#324;ski <***@wp.pl> ---
Created attachment 1939
-->
https://www.thewildbeast.co.uk/claws-mail/bugzilla/attachment.cgi?id=1939&action=edit
small fix for diff detection from git

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4130

--- Comment #3 from Jakub Kici&#324;ski <***@wp.pl> ---
Created attachment 1940
-->
https://www.thewildbeast.co.uk/claws-mail/bugzilla/attachment.cgi?id=1940&action=edit
the actual feature

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4130

--- Comment #4 from wwp <***@claws-mail.org> ---
Interesting, I'm currently running CM w/ this patch applied, will see if I get
false positives or negatives.
BTW, some changes in 3.16.0-191-g0c28ce4 may indicate that it would be better
to match all known signatures instead of checking for "-- \n" only.

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4130

--- Comment #5 from Olivier Brunel <***@jjacky.com> ---
For what it's worth, I've been running claws with those patches for years now
without (noticing) any issues. Great addition IMO.

Also for reference, original bug is:
https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3035

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4130

--- Comment #6 from Paul <***@claws-mail.org> ---
*** Bug 3035 has been marked as a duplicate of this bug. ***