[Users] [Bug 4121] New: Moving a subfolder in another folder erases its processing rules

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4121

Bug ID: 4121
Summary: Moving a subfolder in another folder erases its
processing rules
Classification: Unclassified
Product: Claws Mail
Version: GIT
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P3
Component: Filtering
Assignee: ***@lists.claws-mail.org
Reporter: ***@anchev.net

version 3.17.0git172

STR:

1. Have a folder structure like:

+ My Feeds (RSSyl)
++ Folder1
+++ Feed
++ Folder2

2. Right click "Feed" and create a processing rule for it

3. Move "Feed" in "Folder2"

4. Right click "Feed" to check processing rules

EXPECTED:

The rule created in step 2 should be there.

ACTUAL:

There are no rules.

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4121

--- Comment #1 from ***@lists.claws-mail.org ---
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog 2018-11-18 18:24:05.268296877 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=acf535ca86d1a52902646c6248f7446e10899df2
Author: Paul <***@claws-mail.org>
Date: Sun Nov 18 17:23:35 2018 +0000

fix bug where creating a new folder wth inheriting properties doesn't write
processinf rules

after copying folder with 'inherit properties from parent folder' set,
the processing rules are (initially) present in the processing rules
dialogue, but are not actually written. So on a restart they are 'lost'.

This is probably the actual bug 4121, ' Moving a subfolder in another
folder erases its processing rules', rather than the description given.

--- Comment #2 from Paul <***@claws-mail.org> ---
(In reply to comment #1)

after copying folder with 'inherit properties from parent folder' set,

What i meant to say was 'when creating a new folder' rather than 'after copy
folder'.

Moving this folder after creating it thus will not carry over the unsaved
processing rules, which is probably what you meant to say.

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4121

--- Comment #3 from George <***@anchev.net> ---
No, I didn't mean to say anything about copying or creating a folder but about
moving it as this is what I did: I simply dragged and dropped it in another
folder.

Anyway this commit seems to fix it.

Thanks :)

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4121

Paul <***@claws-mail.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #4 from Paul <***@claws-mail.org> ---
I could not reproduce what you described, only what I fixed. My fix did not
alter (for me) what you described.

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4121

--- Comment #5 from George <***@anchev.net> ---
I see. Hm. I don't know if that changes the STR essentially but what I actually
did initially was:

1. Have a folder structure like:

+ My Feeds (RSSyl)
++ Folder1 (no any processing rules)
+++ Feed (with some processing rules)

2. Create Folder2 and structure becomes

+ My Feeds (RSSyl)
++ Folder1
+++ Feed
++ Folder2

3. Drag'n'drop Feed into Folder2

And the result was: the processing rules for Feed were lost.