[Users] [Bug 4132] New: "Mark all as (un)read" dialog appears when acting on 1 message only

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4132

Bug ID: 4132
Summary: "Mark all as (un)read" dialog appears when acting on 1
message only
Classification: Unclassified
Product: Claws Mail
Version: GIT
Hardware: PC
OS: Windows NT
Status: NEW
Severity: normal
Priority: P3
Component: Folders
Assignee: ***@lists.claws-mail.org
Reporter: ***@anchev.net

version 3.17.0git188

STR:

1. Open a folder (mail or RSSyl) containing only 1 message
2. Click to select the message
3. Message->Mark->Mark as read (or as unread)

EXPECTED:

The message should be marked as read (or as unread, respectively) because it is
already selected and the action is performed on it only.

ACTUAL:

The "Mark all as (un)read" dialog box appears asking "Do you really want to
mark all mails in this folder as read?"

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4132

Paul <***@claws-mail.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Hardware|PC |All
OS|Windows NT |All

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4132

wwp <***@claws-mail.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Hardware|All |PC
OS|All |Windows NT

--- Comment #1 from wwp <***@claws-mail.org> ---
What you describe is a bit wrong or fuzzy.

Your scenario mentions, at step 3: Message->Mark->Mark as read.

But the "Mark all as read" dialog you're dealing with is bound to the feature
Message->Mark->Mark ALL as read (see the ALL) (and the recursive one).

Note that this "Mark all as read", whatever called from the Message menu or a
folder's context menu, will show the confirmation dialog whatever "all" implies
1 or 2 or 3 or.. any amount of messages in folder, selected or not. It's about
marking all messages in folder, not all *selected* messages.
And you'll get the dialog until you uncheck "Show this message next time" in it
(or uncheck "Confirm when marking all messages as read or unread" in the
preferences Display->Summaries->Message list.

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4132

wwp <***@claws-mail.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Hardware|PC |All
OS|Windows NT |All

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4132

wwp <***@claws-mail.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Version|GIT |3.17.0

--- Comment #2 from ***@lists.claws-mail.org ---
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog 2018-12-02 12:16:06.992698541 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=f21dc9270747cba5f1a99051984f04d71455ae1d
Author: Paul <***@claws-mail.org>
Date: Sun Dec 2 11:15:11 2018 +0000

fix bug 4132, '"Mark all as (un)read" dialog appears when acting on 1
message only'

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4132

Paul <***@claws-mail.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4132

--- Comment #3 from wwp <***@claws-mail.org> ---
Sorry George, I miserably failed in seeing that corner case, by not believing
your: when a folder contains only one message, there's always a selection
(that's what I didn't expect) and the selection is equal "all messages"
(obviously). This condition raises the dialog, it should not. Paul fixed the
case, thanks for reporting!

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4132

George <***@anchev.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---

--- Comment #4 from George <***@anchev.net> ---
No problem wwp, it happens.

I have rebuild CM (using version 3.17.0git193 now) and I notice that "Mark as
read" works fine now. However "Mark as unread" still works the old (wrong) way
(i.e. like "Mark all as unread").

Would you guys please consider fixing that one too?

Thanks.

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4132

Paul <***@claws-mail.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED

--- Comment #5 from ***@lists.claws-mail.org ---
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog 2018-12-02 13:14:02.758381853 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=7d856421906969bedfae33f12d930fb91446ac24
Author: Paul <***@claws-mail.org>
Date: Sun Dec 2 12:13:45 2018 +0000

complete fix for bug 4132

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4132

--- Comment #6 from George <***@anchev.net> ---
Excellent.
Thanks Paul!