[Users] [Bug 4038] New: Make enum RecvProtocol (prefs_account.h) extensible

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4038

Bug ID: 4038
Summary: Make enum RecvProtocol (prefs_account.h) extensible
Classification: Unclassified
Product: Claws Mail
Version: GIT
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P3
Component: Other
Assignee: ***@lists.claws-mail.org
Reporter: ***@gmail.com

Hello!

Regarding wizard.c (Line 170):

{"recvtype", A_POP3, &tmpl.recvtype, P_INT, NULL, NULL, NULL},

Above code works just because A_POP3 is the first element of an 0-based enum.
If any change is made to enum RecvProtocol which makes A_POP3 != 0 then that's
a recipe for SegFault.

Honestly, current arrangement isn't quite ideal for extending the receive
protocols.

Possible solutions:
1. use a static array of enum values ("0", "1", "2") or
2. simply use "0" instead of A_POP3 with a comment

Above 2 approaches will be still tied to enum RecvProtocol and thus will
require an update if the enum RecvProtocol is changed. But at least there wont
be any SegFault.

[n***@thewildbeast.co.uk]

https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=4038

--- Comment #1 from Andrej Kacian <***@kacian.sk> ---
Created attachment 1941
-->
https://www.thewildbeast.co.uk/claws-mail/bugzilla/attachment.cgi?id=1941&action=edit
Rework recvtype in wizard.c

Attached patch makes "recvtype" store combobox index of desired default option,
and the actual protocol number is pulled from the relevant row's data pointer
in the combobox. That way we do not care whether the actual wanted default
protocol has number 0 or not.

This is probably the simplest solution to this problem. A more proper solution
(one that would ultimately likely simplify a lot more than just this) would be
to modify our pref system to use GValue type for the default value in the
PrefParam struct, but that's a rather complex change.